cybercinch/go-semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 14 Wiki Activity

chore(util/github-release): fix golint issues

Browse Source
This commit is contained in:
fwiedmann
2019-08-08 20:44:33 +02:00
parent 428514a1ef
commit ff82ec7acd
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/releaser/github/github.go
View File

@@ -98,15 +98,15 @@ func (g *Client) CreateRelease(releaseVersion *shared.ReleaseVersion, generatedC
Prerelease: &prerelease, Prerelease: &prerelease,
}) })
if err != nil { if err != nil {
if !strings.Contains(err.Error(), "already_exists") { if strings.Contains(err.Error(), "already_exists") {
return fmt.Errorf("could not create release: %v", err) log.Infof("A release with tag %s already exits, will not perform a release or update", tag)
return nil
} }
log.Infof("A release with tag %s already exits, will not perform a release or update", tag) return fmt.Errorf("could not create release: %v", err)
} else {
g.release = release
log.Debugf("Release repsone: %+v", *release)
log.Infof("Crated release")
} }
g.release = release
log.Debugf("Release repsone: %+v", *release)
log.Infof("Crated release")
return nil return nil
} }

2
internal/releaser/util/util.go
View File

@@ -175,6 +175,7 @@ func Do(client *http.Client, req *http.Request, v interface{}) (*http.Response,
return resp, err return resp, err
} }
// IsValidResult validates response code
func IsValidResult(resp *http.Response) error { func IsValidResult(resp *http.Response) error {
switch resp.StatusCode { switch resp.StatusCode {
case 200, 201, 202, 204, 304: case 200, 201, 202, 204, 304:
@@ -184,6 +185,7 @@ func IsValidResult(resp *http.Response) error {
} }
} }
// ShouldRetry request
func ShouldRetry(resp *http.Response) bool { func ShouldRetry(resp *http.Response) bool {
if resp.StatusCode == http.StatusTooManyRequests { if resp.StatusCode == http.StatusTooManyRequests {
return true return true