From ff82ec7acd295a472be78d6242ab21d4136233e2 Mon Sep 17 00:00:00 2001 From: fwiedmann Date: Thu, 8 Aug 2019 20:44:33 +0200 Subject: [PATCH] chore(util/github-release): fix golint issues --- internal/releaser/github/github.go | 14 +++++++------- internal/releaser/util/util.go | 2 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/internal/releaser/github/github.go b/internal/releaser/github/github.go index 8750251..0eb9b4d 100644 --- a/internal/releaser/github/github.go +++ b/internal/releaser/github/github.go @@ -98,15 +98,15 @@ func (g *Client) CreateRelease(releaseVersion *shared.ReleaseVersion, generatedC Prerelease: &prerelease, }) if err != nil { - if !strings.Contains(err.Error(), "already_exists") { - return fmt.Errorf("could not create release: %v", err) + if strings.Contains(err.Error(), "already_exists") { + log.Infof("A release with tag %s already exits, will not perform a release or update", tag) + return nil } - log.Infof("A release with tag %s already exits, will not perform a release or update", tag) - } else { - g.release = release - log.Debugf("Release repsone: %+v", *release) - log.Infof("Crated release") + return fmt.Errorf("could not create release: %v", err) } + g.release = release + log.Debugf("Release repsone: %+v", *release) + log.Infof("Crated release") return nil } diff --git a/internal/releaser/util/util.go b/internal/releaser/util/util.go index b535df2..a1a476a 100644 --- a/internal/releaser/util/util.go +++ b/internal/releaser/util/util.go @@ -175,6 +175,7 @@ func Do(client *http.Client, req *http.Request, v interface{}) (*http.Response, return resp, err } +// IsValidResult validates response code func IsValidResult(resp *http.Response) error { switch resp.StatusCode { case 200, 201, 202, 204, 304: @@ -184,6 +185,7 @@ func IsValidResult(resp *http.Response) error { } } +// ShouldRetry request func ShouldRetry(resp *http.Response) bool { if resp.StatusCode == http.StatusTooManyRequests { return true