cybercinch/go-semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 14 Wiki Activity

chore(internal/releaser/github): remove unused token initialization in ValidateConfig() because token gets initialiazed in New()

Browse Source
This commit is contained in:
Felix Wiedmann
2019-06-18 21:20:30 +02:00
parent f65b90975f
commit b0d28b1ce7
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/releaser/github/github.go
View File

@@ -5,7 +5,6 @@ import (
"fmt" "fmt"
"net/http" "net/http"
"os" "os"
"strings"
"github.com/Nightapes/go-semantic-release/internal/releaser/util" "github.com/Nightapes/go-semantic-release/internal/releaser/util"
"github.com/Nightapes/go-semantic-release/internal/shared" "github.com/Nightapes/go-semantic-release/internal/shared"
@@ -78,12 +77,6 @@ func (g Client) ValidateConfig() error {
return fmt.Errorf("github User is not set") return fmt.Errorf("github User is not set")
} }
envName := fmt.Sprintf("%s_ACCESS_TOKEN", strings.ToUpper(GITHUB))
token, isSet := os.LookupEnv(envName)
if !isSet {
return fmt.Errorf("can not find environment variable %s", envName)
}
g.token = token
return nil return nil
} }
@@ -104,11 +97,11 @@ func (g Client) CreateRelease(releaseVersion *shared.ReleaseVersion, generatedCh
}) })
if err != nil { if err != nil {
return fmt.Errorf("could not create release: %v", err) return fmt.Errorf("Could not create release: %v", err)
} }
if resp.StatusCode >= http.StatusBadRequest { if resp.StatusCode >= http.StatusBadRequest {
return fmt.Errorf("ould not create release: response statuscode: %s", resp.Status) return fmt.Errorf("Could not create release: response statuscode: %s", resp.Status)
} }
log.Infof("Crated release") log.Infof("Crated release")