From b0d28b1ce79a246094e9912e7f9aad8eaa0a2ef1 Mon Sep 17 00:00:00 2001 From: Felix Wiedmann Date: Tue, 18 Jun 2019 21:20:30 +0200 Subject: [PATCH] chore(internal/releaser/github): remove unused token initialization in ValidateConfig() because token gets initialiazed in New() --- internal/releaser/github/github.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/internal/releaser/github/github.go b/internal/releaser/github/github.go index 23e1dce..a47d3fa 100644 --- a/internal/releaser/github/github.go +++ b/internal/releaser/github/github.go @@ -5,7 +5,6 @@ import ( "fmt" "net/http" "os" - "strings" "github.com/Nightapes/go-semantic-release/internal/releaser/util" "github.com/Nightapes/go-semantic-release/internal/shared" @@ -78,12 +77,6 @@ func (g Client) ValidateConfig() error { return fmt.Errorf("github User is not set") } - envName := fmt.Sprintf("%s_ACCESS_TOKEN", strings.ToUpper(GITHUB)) - token, isSet := os.LookupEnv(envName) - if !isSet { - return fmt.Errorf("can not find environment variable %s", envName) - } - g.token = token return nil } @@ -104,11 +97,11 @@ func (g Client) CreateRelease(releaseVersion *shared.ReleaseVersion, generatedCh }) if err != nil { - return fmt.Errorf("could not create release: %v", err) + return fmt.Errorf("Could not create release: %v", err) } if resp.StatusCode >= http.StatusBadRequest { - return fmt.Errorf("ould not create release: response statuscode: %s", resp.Status) + return fmt.Errorf("Could not create release: response statuscode: %s", resp.Status) } log.Infof("Crated release")