Bump engine.io and karma

Bumps [engine.io](https://github.com/socketio/engine.io) to 6.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated together. Updates `engine.io` from 3.2.0 to 6.2.1 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/engine.io/compare/3.2.0...6.2.1) Updates `karma` from 3.0.0 to 6.4.1 - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v3.0.0...v6.4.1) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect - dependency-name: karma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
2022-11-22 16:49:57 +00:00
9 changed files with 845 additions and 590 deletions
--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
    "codelyzer": "~4.3.0",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
-    "karma": "~3.0.0",
+    "karma": "~6.4.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.1",
    "karma-jasmine": "~1.1.2",
--- a/src/app/dashboard/dashboard.html
+++ b/src/app/dashboard/dashboard.html
@@ -20,7 +20,7 @@
          <h5>Current spending</h5>
        </div>
        <div class="col-4 amount">
-          <h5>{{expenseAmount | currencyFormat:org.precision:org.currency}}</h5>
+          <h5>{{expenseAmount | currencyFormat:org.precision}}</h5>
        </div>
      </div>
      <div class="row" *ngFor="let expense of expenseAccounts" [routerLink]="'/accounts/'+expense.id+'/transactions'" [ngClass]="{hidden: hiddenExpenses[expense.id]}">
@@ -28,7 +28,7 @@
          {{expense.fullName | accountName:2}}
        </div>
        <div class="col-4 amount">
-          {{expense.nativeBalanceCost | currencyFormat:org.precision:org.currency}}
+          {{expense.nativeBalanceCost | currencyFormat:org.precision}}
        </div>
      </div>
      <div class="row">
@@ -59,11 +59,10 @@
          {{recentTx.tx.date | datetz:"M/D":org.timezone}}
        </div>
        <div class="col-5 col-md-6 description">
-          <div class="primary">{{recentTx.tx.description}}</div>
-          <div class="additional">{{recentTx.account.fullName}}</div>
+          {{recentTx.tx.description}}
        </div>
        <div class="col-4 col-md-4 amount" [ngClass]="{'negative': recentTx.split.amount > 0}">
-          {{-recentTx.split.amount | currencyFormat:recentTx.account.precision:recentTx.account.currency}}
+          {{-recentTx.split.amount | currencyFormat:recentTx.account.precision}}
        </div>
      </div>
      <div class="row">
--- a/src/app/dashboard/dashboard.scss
+++ b/src/app/dashboard/dashboard.scss
@@ -41,19 +41,6 @@
  .expanded .hidden {
    display: flex
  }
-  .row {
-    padding-bottom: 1em;
-    .description {
-      .primary:empty::after {
-        content: ".";
-        visibility: hidden;
-      }
-      .additional {
-        font-size: small;
-        color: $black;
-      }
-    }
-  }
 }

@media (max-width: 767px) {
--- a/src/app/org/neworg.html
+++ b/src/app/org/neworg.html
@@ -53,7 +53,7 @@
      </div>
      <div class="form-check">
        <input formControlName="createDefaultAccounts" id="createDefaultAccounts3" type="radio" class="form-check-input" value="personal" />
-        <label for="createDefaultAccounts3" class="form-check-label">Personal accounts</label>
+        <label for="createDefaultAccounts2" class="form-check-label">Personal accounts</label>
      </div>
    </div>
    <p *ngIf="error" class="error">
--- a/src/app/org/org.html
+++ b/src/app/org/org.html
@@ -160,7 +160,7 @@
      </div>
      <div class="form-check">
        <input formControlName="createDefaultAccounts" id="createDefaultAccounts3" type="radio" class="form-check-input" value="personal" />
-        <label for="createDefaultAccounts3" class="form-check-label">Personal accounts</label>
+        <label for="createDefaultAccounts2" class="form-check-label">Personal accounts</label>
      </div>
    </div>
    <p *ngIf="newOrgError" class="error">{{newOrgError.message}}</p>
--- a/src/app/reports/balancesheet.html
+++ b/src/app/reports/balancesheet.html
@@ -29,8 +29,8 @@
        <h4>Assets</h4>
      </div>
      <div class="col-4 amount">
-        <h4 *ngIf="priceSource === 'price'">{{+assetAccount.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}</h4>
-        <h4 *ngIf="priceSource === 'cost'">{{+assetAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4 *ngIf="priceSource === 'price'">{{+assetAccount.totalNativeBalancePrice | currencyFormat:org.precision}}</h4>
+        <h4 *ngIf="priceSource === 'cost'">{{+assetAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
    <div class="row" *ngFor="let account of assetAccounts" [attr.depth]="account.depth">
@@ -39,10 +39,10 @@
        <span *ngIf="!account.children.length"><a [routerLink]="'/accounts/' + account.id + '/transactions'">{{account.name | slice:0:30}}</a></span>
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'price' && account.totalNativeBalancePrice">
-        {{+account.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}
+        {{+account.totalNativeBalancePrice | currencyFormat:org.precision}}
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'cost' && account.totalNativeBalanceCost">
-        {{+account.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}
+        {{+account.totalNativeBalanceCost | currencyFormat:org.precision}}
      </div>
    </div>
    <div class="row">
@@ -55,8 +55,8 @@
        <h4>Liabilities</h4>
      </div>
      <div class="col-4 amount">
-        <h4 *ngIf="priceSource === 'price'">{{-liabilityAccount.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}</h4>
-        <h4 *ngIf="priceSource === 'cost'">{{-liabilityAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4 *ngIf="priceSource === 'price'">{{-liabilityAccount.totalNativeBalancePrice | currencyFormat:org.precision}}</h4>
+        <h4 *ngIf="priceSource === 'cost'">{{-liabilityAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
    <div class="row" *ngFor="let account of liabilityAccounts" [attr.depth]="account.depth">
@@ -65,10 +65,10 @@
        <span *ngIf="!account.children.length"><a [routerLink]="'/accounts/' + account.id + '/transactions'">{{account.name | slice:0:30}}</a></span>
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'price' && account.totalNativeBalancePrice">
-        {{-account.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}
+        {{-account.totalNativeBalancePrice | currencyFormat:org.precision}}
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'cost' && account.totalNativeBalanceCost">
-        {{-account.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}
+        {{-account.totalNativeBalanceCost | currencyFormat:org.precision}}
      </div>
    </div>
    <div class="row" depth="1">
@@ -76,8 +76,8 @@
        <h4>Equity</h4>
      </div>
      <div class="col-4 amount">
-        <h4 *ngIf="priceSource === 'price'">{{-equityAccount.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}</h4>
-        <h4 *ngIf="priceSource === 'cost'">{{-equityAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4 *ngIf="priceSource === 'price'">{{-equityAccount.totalNativeBalancePrice | currencyFormat:org.precision}}</h4>
+        <h4 *ngIf="priceSource === 'cost'">{{-equityAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
    <div class="row" *ngFor="let account of equityAccounts" [attr.depth]="account.depth">
@@ -86,10 +86,10 @@
        <span *ngIf="!account.children.length"><a [routerLink]="'/accounts/' + account.id + '/transactions'">{{account.name | slice:0:30}}</a></span>
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'price' && account.totalNativeBalancePrice">
-        {{-account.totalNativeBalancePrice | currencyFormat:org.precision:org.currency}}
+        {{-account.totalNativeBalancePrice | currencyFormat:org.precision}}
      </div>
      <div class="col-4 amount" *ngIf="priceSource === 'cost' && account.totalNativeBalanceCost">
-        {{-account.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}
+        {{-account.totalNativeBalanceCost | currencyFormat:org.precision}}
      </div>
    </div>
  </div>
--- a/src/app/reports/income.html
+++ b/src/app/reports/income.html
@@ -24,7 +24,7 @@
        <h4>Income</h4>
      </div>
      <div class="col-4 amount">
-        <h4>{{-incomeAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4>{{-incomeAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
    <div class="row" *ngFor="let account of incomeAccounts" [attr.depth]="account.depth">
@@ -33,7 +33,7 @@
        <span *ngIf="!account.children.length"><a [routerLink]="'/accounts/' + account.id + '/transactions'">{{account.name | slice:0:30}}</a></span>
      </div>
      <div class="col-4 amount" *ngIf="account.totalNativeBalanceCost">
-        {{-account.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}
+        {{-account.totalNativeBalanceCost | currencyFormat:org.precision}}
      </div>
    </div>
    <div class="row" depth="1">
@@ -41,7 +41,7 @@
        <h4>Expenses</h4>
      </div>
      <div class="col-4 amount">
-        <h4>{{expenseAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4>{{expenseAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
    <div class="row" *ngFor="let account of expenseAccounts" [attr.depth]="account.depth">
@@ -50,7 +50,7 @@
        <span *ngIf="!account.children.length"><a [routerLink]="'/accounts/' + account.id + '/transactions'">{{account.name | slice:0:30}}</a></span>
      </div>
      <div class="col-4 amount" *ngIf="account.totalNativeBalanceCost">
-        {{account.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}
+        {{account.totalNativeBalanceCost | currencyFormat:org.precision}}
      </div>
    </div>
    <div class="row" depth="1">
@@ -58,7 +58,7 @@
        <h4>Net Income</h4>
      </div>
      <div class="col-4 amount">
-        <h4>{{-incomeAccount.totalNativeBalanceCost - expenseAccount.totalNativeBalanceCost | currencyFormat:org.precision:org.currency}}</h4>
+        <h4>{{-incomeAccount.totalNativeBalanceCost - expenseAccount.totalNativeBalanceCost | currencyFormat:org.precision}}</h4>
      </div>
    </div>
  </div>
--- a/src/app/shared/currency-format.pipe.ts
+++ b/src/app/shared/currency-format.pipe.ts
@@ -1,16 +1,7 @@
 import { Pipe, PipeTransform } from '@angular/core';
 import { DecimalPipe } from '@angular/common';

-// Format the currency according to the user's browser locale.
-//
-// Some currencies share the same symbol (e.g. $ is used for USD and CAN).
-// Ideally, the user experience should not be confusing if different accounts
-// have conflicting symbols. One solution might be to always show the ISO
-// currency code for accounts with mixes currencies. Another solution would be
-// to let the user configure how the currency is displayed on a per-currency
-// or per-account basis.
-
-@Pipe({ name: 'currencyFormat' })
+@Pipe({name: 'currencyFormat'})
 export class CurrencyFormatPipe implements PipeTransform {
  constructor(private decimalPipe: DecimalPipe) {
  }
@@ -20,12 +11,17 @@ export class CurrencyFormatPipe implements PipeTransform {
      return '';
    }

-    // note: we can drop the cast to any if we change the ts target from es5 to es2020 or newer.
-    return Intl.NumberFormat(navigator.language, {
-      style: "currency",
-      currency,
-      minimumFractionDigits: precision,
-      signDisplay: "negative",
-    } as any).format(amount / Math.pow(10, precision));
+    let prefix = amount < 0 ? '-' : '';
+
+    if(currency === 'USD') {
+      prefix += '$';
+    }
+
+    let minDigits = Math.min(2, precision);
+    
+    return prefix + 
+      this.decimalPipe.transform(
+        Math.abs(amount) / Math.pow(10, precision),
+        '1.' + minDigits + '-' + precision);
  }
 }