cybercinch/go-semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 14 Wiki Activity

fix(internal/assets): close zip writer before closing zip file

Browse Source
This commit is contained in:
fwiedmann
2020-05-21 00:45:59 +02:00
parent 11acc95a34
commit c84b51d18c
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/assets/asset.go
View File

@@ -149,7 +149,6 @@ func (a *Asset) ZipFile() (string, error) {
}
zipWriter := zip.NewWriter(zipFile)
defer zipWriter.Close()
fileToZipHeader, err := zip.FileInfoHeader(fileToZipInfo)
if err != nil {
@@ -166,9 +165,15 @@ func (a *Asset) ZipFile() (string, error) {
if _, err = io.Copy(fileToZipWriter, fileToZip); err != nil {
return "", errors.Wrap(err, "Could not zip file")
}
if err := zipWriter.Close(); err != nil {
return "", errors.Wrap(err, fmt.Sprintf("Could not close zipwriter for zip %s", a.path))
}
if err := zipFile.Close(); err != nil {
return "", errors.Wrap(err, "Could not close file")
}
a.zippedPath, err = filepath.Abs(zipFile.Name())
return a.zippedPath, err
}