Merge branch 'master' of github.com:Nightapes/go-semantic-release into remove/draft

This commit is contained in:
fwiedmann
2019-08-22 00:12:24 +02:00
parent 2eb64f153a
commit a2fc03c64d
10 changed files with 128 additions and 19 deletions

View File

@@ -32,7 +32,7 @@ type Client struct {
func New(c *config.GitHubProvider) (*Client, error) {
var err error
if c.AccessToken, err = util.GetAccessToken(GITHUB); err != nil {
if c.AccessToken, err = util.GetAccessToken("GITHUB_TOKEN"); err != nil {
return &Client{}, err
}
ctx := context.Background()

View File

@@ -143,19 +143,19 @@ func initHTTPServer(respCode int, body string) *httptest.Server {
func TestNew(t *testing.T) {
for _, testOject := range testNewClient {
if testOject.valid {
os.Setenv("GITHUB_ACCESS_TOKEN", "XXX")
os.Setenv("GITHUB_TOKEN", "XXX")
}
_, err := github.New(&testOject.config)
assert.Equal(t, testOject.valid, err == nil)
os.Unsetenv("GITHUB_ACCESS_TOKEN")
os.Unsetenv("GITHUB_TOKEN")
}
}
func TestGetCommitURL(t *testing.T) {
os.Setenv("GITHUB_ACCESS_TOKEN", "XX")
os.Setenv("GITHUB_TOKEN", "XX")
for _, testOject := range testNewClient {
client, _ := github.New(&testOject.config)
actualURL := client.GetCommitURL()
@@ -168,12 +168,12 @@ func TestGetCommitURL(t *testing.T) {
assert.EqualValues(t, expectedURL, actualURL)
}
}
os.Unsetenv("GITHUB_ACCESS_TOKEN")
os.Unsetenv("GITHUB_TOKEN")
}
func TestGetCompareURL(t *testing.T) {
os.Setenv("GITHUB_ACCESS_TOKEN", "XX")
os.Setenv("GITHUB_TOKEN", "XX")
for _, testOject := range testNewClient {
client, _ := github.New(&testOject.config)
actualURL := client.GetCompareURL("1", "2")
@@ -186,12 +186,12 @@ func TestGetCompareURL(t *testing.T) {
assert.EqualValues(t, expectedURL, actualURL)
}
}
os.Unsetenv("GITHUB_ACCESS_TOKEN")
os.Unsetenv("GITHUB_TOKEN")
}
func TestValidateConfig(t *testing.T) {
os.Setenv("GITHUB_ACCESS_TOKEN", "XX")
os.Setenv("GITHUB_TOKEN", "XX")
for _, testOject := range testHelperMethod {
client, _ := github.New(&testOject.config)
err := client.ValidateConfig()
@@ -199,11 +199,11 @@ func TestValidateConfig(t *testing.T) {
assert.Equal(t, testOject.valid, err == nil)
}
os.Unsetenv("GITHUB_ACCESS_TOKEN")
os.Unsetenv("GITHUB_TOKEN")
}
func TestCreateRelease(t *testing.T) {
os.Setenv("GITHUB_ACCESS_TOKEN", "XX")
os.Setenv("GITHUB_TOKEN", "XX")
for _, testObejct := range testReleases {
if testObejct.valid {
@@ -230,6 +230,6 @@ func TestCreateRelease(t *testing.T) {
assert.Error(t, err)
}
}
os.Unsetenv("GITHUB_ACCESS_TOKEN")
os.Unsetenv("GITHUB_TOKEN")
}