From 581b62d3249b0c48e194b28cd6f17d64ee4f7ee0 Mon Sep 17 00:00:00 2001 From: fwiedmann Date: Mon, 22 Jul 2019 18:11:48 +0200 Subject: [PATCH] ref(internal/releaser/util): check if asset name ist not empty, open file which should be zipped before create zip file --- internal/releaser/util/util.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/internal/releaser/util/util.go b/internal/releaser/util/util.go index dac0acc..6fc9882 100644 --- a/internal/releaser/util/util.go +++ b/internal/releaser/util/util.go @@ -45,7 +45,9 @@ func GetAccessToken(providerName string) (string, error) { func PrepareAssets(repository string, assets []config.Asset) ([]*string, error) { filesToUpload := []*string{} for _, asset := range assets { - if asset.Compress { + if asset.Name == "" { + return nil, fmt.Errorf("Asset name declaration is empty, please check your configuration file") + } else if asset.Compress { log.Debugf("Asset %s will now be compressed", asset.Name) log.Debugf("Repo url %s", repository) zipNameWithPath, err := zipFile(repository, asset.Name) @@ -65,6 +67,12 @@ func PrepareAssets(repository string, assets []config.Asset) ([]*string, error) // ZipFile compress given file in zip format func zipFile(repository string, file string) (string, error) { + fileToZip, err := os.Open(repository + "/" + file) + if err != nil { + return "", err + } + defer fileToZip.Close() + zipFileName := fmt.Sprintf("%s/%s.zip", strings.TrimSuffix(repository, "/"), file) zipFile, err := os.Create(zipFileName) @@ -75,12 +83,6 @@ func zipFile(repository string, file string) (string, error) { defer zipFile.Close() - fileToZip, err := os.Open(repository + "/" + file) - if err != nil { - return "", err - } - defer fileToZip.Close() - fileToZipInfo, err := fileToZip.Stat() if err != nil { return "", err