Remove dead legacy CMD_API_SHOW_ALL_DOMAINS parser #5

New Issue

guisea · 2026-02-18T11:01:46+13:00

guisea commented

2026-02-18 11:01:46 +13:00

_parse_da_domain_list in app/reconciler.py parses the old URL-encoded list[]=domain.com&... format from CMD_API_SHOW_ALL_DOMAINS. This endpoint is no longer used — the reconciler now calls CMD_DNS_ADMIN?json=yes which always returns JSON.

The method is only reachable via a JSON decode exception fallback, which is unreachable in practice.

Action:

Remove _parse_da_domain_list
Remove the from urllib.parse import parse_qs import
Replace the JSON decode fallback except block with a hard error (return None, skip server)

Prerequisite: Confirm no other callers in the codebase before removing.

`_parse_da_domain_list` in `app/reconciler.py` parses the old URL-encoded `list[]=domain.com&...` format from `CMD_API_SHOW_ALL_DOMAINS`. This endpoint is no longer used — the reconciler now calls `CMD_DNS_ADMIN?json=yes` which always returns JSON. The method is only reachable via a JSON decode exception fallback, which is unreachable in practice. **Action:** - Remove `_parse_da_domain_list` - Remove the `from urllib.parse import parse_qs` import - Replace the JSON decode fallback `except` block with a hard error (return `None`, skip server) **Prerequisite:** Confirm no other callers in the codebase before removing.

guisea added the tech-debt label 2026-02-18 11:01:46 +13:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cybercinch/directdnsonly#5