You've already forked directdnsonly
Migrate SQLAlchemy dependency from 1.x to 2.x #4
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
pyproject.toml currently pins
sqlalchemy (<2.0.0). SQLAlchemy 1.x reached end-of-life and 2.0 introduced significant API changes.Breaking changes to address:
session.query(Model)style →select()withsession.execute()session.query(Model).filter_by(...)→session.scalars(select(Model).filter_by(...))Files affected:
directdnsonly/app/db/__init__.pydirectdnsonly/app/db/models/__init__.pydirectdnsonly/worker.pydirectdnsonly/app/reconciler.pydirectdnsonly/app/utils/__init__.pydirectdnsonly/app/backends/coredns_mysql.pydirectdnsonly/app/backends/powerdns_mysql.pyNote: Easier to do once a test suite exists so regressions are caught automatically.