fix: Also now using local_action for host config in checkmk 🐛

tasks/host-configure.yml

@@ -1,62 +1,11 @@
 ---
-- name: cmk_discovery
-  uri:
-    method: POST
-    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=discover_services&mode=refresh{{
-      cmk_auth }}'
-    body: request={"hostname":"{{ instance_name | default(inventory_hostname) }}"}
-    body_format: raw
-    status_code: 200
-    validate_certs: false
-    follow_redirects: true
-  become: false
-  when: cmk_add_host and output.result_code == 0
-  delegate_to: localhost
-  tags: cmk_register
-- name: cmk_apply
-  uri:
-    method: POST
-    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=activate_changes&mode=specific{{
-      cmk_auth }}'
-    body: request={"sites":["{{ cmk_omd_site }}"]}
-    body_format: raw
-    status_code: 200
-    validate_certs: false
-    follow_redirects: true
-  become: false
-  run_once: true
-  when: cmk_add_host and output.result_code == 0
-  delegate_to: localhost
-  tags: cmk_register
-- name: Wait some time
-  pause:
-    seconds: 10
-- name: cmk_discovery x 2
-  uri:
-    method: POST
-    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=discover_services&mode=refresh{{
-      cmk_auth }}'
-    body: request={"hostname":"{{ instance_name | default(inventory_hostname) }}"}
-    body_format: raw
-    status_code: 200
-    validate_certs: false
-    follow_redirects: true
-  become: false
-  when: cmk_add_host and output.result_code == 0
-  delegate_to: localhost
-  tags: cmk_register
-- name: cmk_apply
-  uri:
-    method: POST
-    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=activate_changes&mode=specific{{
-      cmk_auth }}'
-    body: request={"sites":["{{ cmk_omd_site }}"]}
-    body_format: raw
-    status_code: 200
-    validate_certs: false
-    follow_redirects: true
-  become: false
-  run_once: true
-  when: cmk_add_host and output.result_code == 0
-  delegate_to: localhost
-  tags: cmk_register
+- include_tasks: host-configure/legacy.yml
+  when: >
+    cmk_add_host and
+    (cmk_major | int <= 2 and
+    cmk_minor | int < 2 or  cmk_force_install)
+- include_tasks: host-configure/modern.yml
+  when: >
+    cmk_add_host and
+    (cmk_major | int >= 2 and
+    cmk_minor | int >= 2 or  cmk_force_install)

tasks/host-configure/legacy.yml

@@ -0,0 +1,68 @@
+---
+- name: Output contains
+  debug:
+    var: output
+
+- name: cmk_discovery
+  local_action:
+    module: uri
+    method: POST
+    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=discover_services&mode=refresh{{
+      cmk_auth }}'
+    body: request={"hostname":"{{ instance_name | default(inventory_hostname) }}"}
+    body_format: raw
+    status_code: 200
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  when: cmk_add_host and output.id != ""
+  tags: cmk_register
+
+- name: cmk_apply
+  local_action:
+    module: uri
+    method: POST
+    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=activate_changes&mode=specific{{
+      cmk_auth }}'
+    body: request={"sites":["{{ cmk_omd_site }}"]}
+    body_format: raw
+    status_code: 200
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  run_once: true
+  when: cmk_add_host and output.result_code == 0
+  delegate_to: localhost
+  tags: cmk_register
+- name: Wait some time
+  pause:
+    seconds: 10
+- name: cmk_discovery x 2
+  local_action:
+    module: uri
+    method: POST
+    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=discover_services&mode=refresh{{
+      cmk_auth }}'
+    body: request={"hostname":"{{ instance_name | default(inventory_hostname) }}"}
+    body_format: raw
+    status_code: 200
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  when: cmk_add_host and output.result_code == 0
+  tags: cmk_register
+- name: cmk_apply
+  local_action:
+    module: uri
+    method: POST
+    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/webapi.py?action=activate_changes&mode=specific{{
+      cmk_auth }}'
+    body: request={"sites":["{{ cmk_omd_site }}"]}
+    body_format: raw
+    status_code: 200
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  run_once: true
+  when: cmk_add_host and output.result_code == 0
+  tags: cmk_register

tasks/host-configure/modern.yml

@@ -0,0 +1,57 @@
+---
+- name: Output contains
+  debug:
+    var: output
+
+- name: cmk_discovery
+  local_action:
+    module: uri
+    method: POST
+    url: "{{ cmk_api_url }}/domain-types/service_discovery_run/actions/start/invoke"
+    headers:
+      Authorization: "Bearer {{ cmk_username }} {{ cmk_secret }}"
+      Accept: application/json
+      Content-Type: application/json
+    body_format: raw
+    body: |
+      {
+        "host_name": "{{ inventory_hostname | upper }}",
+        "mode": "fix_all"
+      }
+    status_code: 200
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  when: cmk_add_host and res_add.status != 400 and output.id != ""
+  tags: cmk_register
+
+- name: Just Waiting
+  pause:
+    seconds: 20
+
+- name: cmk_apply
+  local_action:
+    module: uri
+    method: POST
+    url: '{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/api/1.0/domain-types/activation_run/actions/activate-changes/invoke'
+    headers:
+      Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}
+      Accept: application/json
+      If-Match: "*"
+    body_format: json
+    body:
+      redirect: false
+      sites:
+       - "{{ cmk_omd_site }}"
+      force_foreign_changes: false
+    status_code: [200]
+    validate_certs: false
+    follow_redirects: true
+  become: false
+  run_once: true
+  when: cmk_add_host and res_add.status != 400 and output.id != ""
+  tags: cmk_register
+
+- name: Wait some time
+  pause:
+    seconds: 10

tasks/host-management.yml

@@ -1,6 +1,7 @@
 ---
 - name: Retrieve checkmk version
-  uri:
+  local_action:
+    module: uri
     method: GET
     headers:
       Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}

tasks/host-management/modern.yml

@@ -1,6 +1,7 @@
 ---
 - name: add host to omd (new)
-  uri:
+  local_action:
+    module:  uri
     method: POST
     headers:
       Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}
@@ -18,7 +19,6 @@
     status_code: [200, 400]
   register: res_add
   become: false
-  delegate_to: localhost
   when: >
     cmk_add_host and  cmk_major | int >= 2 and  cmk_minor | int >= 2
 
@@ -28,7 +28,9 @@
   when: cmk_add_host
 
 - name: Host exists fetch etag (new)  # noqa command-instead-of-module
-  shell: |
+  local_action:
+  module:  shell
+  cmd: |
     curl \
     -G \
     -i \
@@ -39,7 +41,6 @@
     "{{ cmk_omd_protocol }}://{{ cmk_omd_host }}/{{ cmk_omd_site }}/check_mk/api/v0/objects/host_config/{{ inventory_hostname | upper }}"
   register: res_host_exists
   become: false
-  delegate_to: localhost
   when: >
     cmk_add_host and (cmk_major | int >= 2 and cmk_minor | int >= 2) and
     (res_add.status == 400 and output.fields.host_name | first | regex_search('already
@@ -54,7 +55,8 @@
     exists.$'))
 
 - name: Update host as already exists? (new)
-  uri:
+  local_action:
+    module: uri
     method: PUT
     headers:
       Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}
@@ -70,7 +72,6 @@
     status_code: [200]
   register: res
   become: false
-  delegate_to: localhost
   when: >
     cmk_add_host and  (cmk_major | int >= 2 and  cmk_minor | int >= 2) and
     (res_add.status == 400 and output.fields.host_name | first | regex_search('already
@@ -82,7 +83,8 @@
   when: cmk_add_host
 
 - name: cmk_discovery (new)
-  uri:
+  local_action:
+    module: uri
     method: POST
     headers:
       Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}
@@ -98,10 +100,10 @@
     cmk_add_host and  cmk_major | int >= 2 and
     cmk_minor | int >= 2 or
     cmk_force_install
-  delegate_to: localhost
 
 - name: cmk_apply (new)
-  uri:
+  local_action:
+    module: uri
     method: POST
     headers:
       Authorization: Bearer {{ cmk_username }} {{ cmk_secret }}
@@ -120,4 +122,3 @@
   when: >
     cmk_add_host and cmk_major | int >= 2 and
     cmk_minor | int >= 2 or cmk_force_install
-  delegate_to: localhost